Skip to content

feat(cli): add experimental rpty command #16700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 26, 2025
Merged

feat(cli): add experimental rpty command #16700

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6beaf7c
chore(cli): skip TestDotfiles if GPG_TTY is set to avoid hanging
johnstcn Feb 25, 2025
02463f3
chore(cli): rename exp commands to have exp_ prefix
johnstcn Feb 25, 2025
a9ff045
feat(cli): add experimental rpty command
johnstcn Feb 25, 2025
b98d413
address PR feedback
johnstcn Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore(cli): skip TestDotfiles if GPG_TTY is set to avoid hanging
  • Loading branch information
@johnstcn
johnstcn committed Feb 26, 2025
commit 6beaf7c4cbf5da0b35154a7cb190db226fd15cb3
4 changes: 4 additions & 0 deletions cli/dotfiles_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ import (

func TestDotfiles(t *testing.T) {
t.Parallel()
// This test will time out if the user has commit signing enabled.
if _, gpgTTYFound := os.LookupEnv("GPG_TTY"); gpgTTYFound {
t.Skip("GPG_TTY is set, skipping test to avoid hanging")
}
Comment on lines +20 to +23
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review: decided to add this drive-by since running the tests locally was hanging for me

t.Run("MissingArg", func(t *testing.T) {
t.Parallel()
inv, _ := clitest.New(t, "dotfiles")
Expand Down