feat: support session audit log #16703
Merged
+85
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mafredri open questions:
|
mafredri
approved these changes
Feb 26, 2025
site/src/pages/AuditPage/AuditLogRow/AuditLogDescription/AuditLogDescription.tsx
Outdated
Show resolved
Hide resolved
| return ( | ||
| <Pill | ||
| css={styles.statusCodePill} | ||
| type={isHttp ? httpStatusColor(code) : code === 0 ? "success" : "error"} |
mafredri
reviewed
Feb 26, 2025
| @@ -232,6 +227,19 @@ export const AuditLogRow: FC<AuditLogRowProps> = ({ | |||
| ); | |||
| }; | |||
|
|
|||
| function StatusPill({ code }: { code: number }) { | |||
| const isHttp = code >= 100; | |||
There was a problem hiding this comment.
Actually, a better measure of http status code may be whether or not this was a connect/disconnect action. Shell errors can be 0-255, but perhaps we should just mark them as 0/1 on the API side, wdyt?
There was a problem hiding this comment.
Hm... I think it works 👍
…LogDescription.tsx Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #15139
Demo:
