Skip to content

feat: include winres metadata in Windows binaries #16706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 28, 2025
Merged

feat: include winres metadata in Windows binaries #16706

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
85e2a6a
feat: include winres metadata in Windows binaries
deansheather Feb 26, 2025
d2c54b3
test CI
deansheather Feb 26, 2025
cf9fc04
fix: add permission for gcloud auth
deansheather Feb 26, 2025
970bf8a
test CI 2
deansheather Feb 26, 2025
35dc760
Revert "test CI 2"
deansheather Feb 26, 2025
5d9c439
Revert "test CI"
deansheather Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test CI 2
  • Loading branch information
@deansheather
deansheather committed Feb 26, 2025
commit 970bf8a6871e7bbe4a00e4d6cc793295bba910a5
23 changes: 11 additions & 12 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1017,7 +1017,6 @@ jobs:
# to main branch.
needs:
- changes
- build-dylib
#if: github.ref == 'refs/heads/main' && needs.changes.outputs.docs-only == 'false' && !github.event.pull_request.head.repo.fork
runs-on: ${{ github.repository_owner == 'coder' && 'depot-ubuntu-22.04-8' || 'ubuntu-22.04' }}
permissions:
Expand Down Expand Up @@ -1091,17 +1090,17 @@ jobs:
- name: Setup GCloud SDK
uses: google-github-actions/setup-gcloud@77e7a554d41e2ee56fc945c52dfd3f33d12def9a # v2.1.4

- name: Download dylibs
uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
with:
name: dylibs
path: ./build

- name: Insert dylibs
run: |
mv ./build/*amd64.dylib ./site/out/bin/coder-vpn-darwin-amd64.dylib
mv ./build/*arm64.dylib ./site/out/bin/coder-vpn-darwin-arm64.dylib
mv ./build/*arm64.h ./site/out/bin/coder-vpn-darwin-dylib.h
#- name: Download dylibs
# uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
# with:
# name: dylibs
# path: ./build

#- name: Insert dylibs
# run: |
# mv ./build/*amd64.dylib ./site/out/bin/coder-vpn-darwin-amd64.dylib
# mv ./build/*arm64.dylib ./site/out/bin/coder-vpn-darwin-arm64.dylib
# mv ./build/*arm64.h ./site/out/bin/coder-vpn-darwin-dylib.h

- name: Build
run: |
Expand Down
Loading