• fix(flake.nix): synchronize playwright version in nix and package.json #16715 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Are we affected by those regressions?

The alternative is to upgrade @playwright/test to 1.50.1.

Are we affected by those regressions?

The alternative is to upgrade @playwright/test to 1.50.1.

I'm not entirely sure. @aslilac @mafredri since you were the last two folks to bump the playwright version, can you weigh in here?

I simply updated to the latest one at the time, so no deeper intention. In general I'd prefer upgrade over downgrade, but no idea what changes have gone in. Regressions from going .2 to .0 don't seem relevant IMO but don't know if we use page.pause() in our tests.

I don't know much about nix, but I really don't like the idea of not being able to use newer versions of a package from an entirely different package manager just because nix says so

This PR focuses not on locking down the Playwright version but ensuring that the browsers required by a specific Playwright version are already pre-installed in the image. If the browsers are not pre-installed, Playwright attempts to download them from the internet, which can negatively impact startup times, bandwidth usage, and reproducibility.

I am OK with upgrading to a newer Playwright version, but the constraint of pre-installing the browsers into the image is firm.

This PR focuses not on locking down the Playwright version but ensuring that the browsers required by a specific Playwright version are already pre-installed in the image. If the browsers are not pre-installed, Playwright attempts to download them from the internet, which can negatively impact startup times, bandwidth usage, and reproducibility.

I am OK with upgrading to a newer Playwright version, but the constraint of pre-installing the browsers into the image is firm.

So this constraint should only affect users of the Nix image? IMO it's a reasonable constraint.

Yes, it causes the Nix image build to exit early if the Nix Playwright version does not match the one specified in package.json, as it cannot guarantee that pnpm playwright:install will be a no-op.

Interestingly, I couldn't find us pre-caching or downloading the browsers in the standard dogfood image, which leads me to conclude that we are re-downloading Google Chrome and friends each time a workspace starts?

does it only affect nix users tho? it places a constraint on what version of playwright we can place in package.json, which affects everyone

which leads me to conclude that we are re-downloading Google Chrome and friends each time a workspace starts?

not on workspace start for everyone, you either have to remember to download them before running the e2e tests or put the download command in your ~/personalize script

not on workspace start for everyone

Maybe I misunderstand our startup script, but we explicitly call pnpm playwright:install as part of it, or am I understanding something wrong?

oh nevermind! I didn't know we added that

Yeah, I just double-checked, and it indeed reinstalls system dependencies and Chromium at each workspace start due to that startup script.

I've refactored this behavior by removing the pnpm playwright:install from the startup script. We're pre-installing the required system dependencies and browser versions in the Dogfood Docker image, which should also significantly increase our startup times for nix and non-nix workspaces.

This also means we're pinning the Playwright version in the Dockerfile, as we cannot access the site's package.json at build time.