Skip to content

chore(cli): fix test flake caused by agent connect race #16725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2025
Merged

chore(cli): fix test flake caused by agent connect race #16725

merged 1 commit into from
Feb 26, 2025

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Feb 26, 2025 •
edited
Loading

Fixes test flake seen here: https://github.com/coder/coder/actions/runs/13552012547/job/37877778883

    exp_rpty_test.go:96: 
        	Error Trace:	/home/runner/work/coder/coder/cli/exp_rpty_test.go:96
        	            				/home/runner/work/coder/coder/cli/ssh_test.go:1963
        	            				/home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.9.linux-amd64/src/runtime/asm_amd64.s:1695
        	Error:      	Received unexpected error:
        	            	running command "coder exp rpty": GET http://localhost:37991/api/v2/workspaceagents/3785b98f-0589-47d2-a3c8-33a55a6c5b29/containers: unexpected status code 400: Agent state is "connecting", it must be in the "connected" state.
        	Test:       	TestExpRpty/Container

@johnstcn johnstcn self-assigned this Feb 26, 2025
@johnstcn johnstcn added the hotfix PRs only. Harmless small change. Only humans may set this. label Feb 26, 2025
cdr-bot[bot]
cdr-bot bot approved these changes Feb 26, 2025
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@johnstcn johnstcn merged commit 2aa749a into main Feb 26, 2025
36 checks passed
@johnstcn johnstcn deleted the cj/flake/exp-rpty-agent-connecting branch February 26, 2025 21:10
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@johnstcn johnstcn

Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@johnstcn