Skip to content

fix: handle undefined job while updating build progress #16732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Feb 27, 2025

Fixes: #15444

We update the build progress with useEffect(), so in theory, a job may somehow become undefined.

Note: TBH I'm not convinced if that prevents the root cause.

@mtojek mtojek self-assigned this Feb 27, 2025
@mtojek mtojek requested a review from BrunoQuaresma February 27, 2025 13:06
@mtojek mtojek marked this pull request as ready for review February 27, 2025 13:06
@mtojek mtojek merged commit 0ea0601 into main Feb 27, 2025
30 checks passed
@mtojek mtojek deleted the 15444-job-started branch February 27, 2025 19:30
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2025
@matifali
Copy link
Member

/cherry-pick release/2.20

@matifali
Copy link
Member

/cherry-pick release/2.19

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message after stopping a workspace
3 participants