refactor: Make workspace machine ephemeral to limit polling #1674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kira-Pilot
reviewed
May 23, 2022
|
|
||
| export const WorkspacePage: React.FC = () => { | ||
| const { workspace: workspaceQueryParam } = useParams() | ||
| const workspaceId = firstOrItem(workspaceQueryParam, null) | ||
|
|
||
| const xServices = useContext(XServiceContext) | ||
| const [workspaceState, workspaceSend] = useActor(xServices.workspaceXService) | ||
| const [workspaceState, workspaceSend] = useMachine(workspaceMachine) |
There was a problem hiding this comment.
so because 'useMachine' accepts a machine instead of a service, it's not persistent?
There was a problem hiding this comment.
Yes, the service is instantiated in the component, and will thus end when the component is unmounted. In the other style, we instantiate the service in the StateContext, so it outlives components.
There was a problem hiding this comment.
useMachine turns a machine into a service, while useActor and useInterpret are ways of connecting to a service. The difference between the latter two is that useActor will give you all the state and the component will rerender on any state change, while useInterpret won't cause unnecessary rerenders, but you need selectors to get pieces of state.
Kira-Pilot
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1491