Skip to content

fix(agent/agentcontainers): remove empty warning if no containers exist #16748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2025
Merged

fix(agent/agentcontainers): remove empty warning if no containers exist #16748

merged 2 commits into from
Feb 28, 2025

Conversation

johnstcn
Copy link
Member

Fixes the current annoying response if no containers are running:

{"containers":null,"warnings":[""]}

@johnstcn johnstcn self-assigned this Feb 28, 2025
@johnstcn johnstcn added the hotfix PRs only. Harmless small change. Only humans may set this. label Feb 28, 2025
cdr-bot[bot]
cdr-bot bot approved these changes Feb 28, 2025
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@johnstcn johnstcn merged commit 6889ad2 into main Feb 28, 2025
30 checks passed
@johnstcn johnstcn deleted the cj/hotfix-agent-containers-lister-blank-warning branch February 28, 2025 11:05
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@johnstcn johnstcn

Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@johnstcn