-
Notifications
You must be signed in to change notification settings - Fork 875
fix: fix deployment settings navigation issues #16780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did the initial review – going to spin up the branch and verify everything else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving tentatively, since I didn't find anything major
Thank you @aslilac @Parkreiner |
/cherry-pick release/2.20 |
As discussed, a minimal patch that fixes some issues discovered at the last hour of the Orgs GA work:
DeploymentSettingsLayout
component may lock you out entirely, incorrectly, because of a bad permission check on the front end