Skip to content

feat(site): allow opening web terminal to container #16797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 4, 2025
Merged

feat(site): allow opening web terminal to container #16797

merged 2 commits into from
Mar 4, 2025

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Mar 4, 2025

No description provided.

@johnstcn johnstcn self-assigned this Mar 4, 2025
@johnstcn johnstcn requested a review from BrunoQuaresma March 4, 2025 10:48
@BrunoQuaresma
Copy link
Collaborator

  • What is the use case to let the user set the container user?
  • Is container user required? Does it work when a container user is not set?

@johnstcn
Copy link
Member Author

johnstcn commented Mar 4, 2025

  • What is the use case to let the user set the container user?

The user may wish to exec into the container as a particular user inside the container (for example, root).

  • Is container user required? Does it work when a container user is not set?

Not required! We can leave it unset.

@BrunoQuaresma BrunoQuaresma merged commit e9f8822 into main Mar 4, 2025
30 checks passed
@BrunoQuaresma BrunoQuaresma deleted the cj/site/terminal-container-params branch March 4, 2025 13:22
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstcn @BrunoQuaresma