Skip to content

fix: display all available settings #16798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025
Merged

fix: display all available settings #16798

merged 2 commits into from
Mar 4, 2025

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Mar 4, 2025

Fixes: #15420

This must have been a regression since OptionValue is able to display Not set when the value is undefined.

Screenshot 2025-03-04 at 13 00 55

@mtojek mtojek self-assigned this Mar 4, 2025
@mtojek mtojek requested review from johnstcn and defelmnq March 4, 2025 12:07
@mtojek mtojek marked this pull request as ready for review March 4, 2025 12:07
@mtojek mtojek marked this pull request as draft March 4, 2025 12:25
@johnstcn
Copy link
Member

johnstcn commented Mar 4, 2025

It looks like the e2e tests consider this change a failure?

@mtojek
Copy link
Member Author

mtojek commented Mar 4, 2025

I have accidentally modified some boolean fields set to false by default. Trying one more time.

@mtojek mtojek marked this pull request as ready for review March 4, 2025 12:47
@mtojek mtojek merged commit 975ea23 into main Mar 4, 2025
30 of 32 checks passed
@mtojek mtojek deleted the 15420-options branch March 4, 2025 14:46
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: some deployments settings are hidden
2 participants