Skip to content

test(cli): improve TestServer/SpammyLogs line count #16814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2025
Merged

test(cli): improve TestServer/SpammyLogs line count #16814

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd1b097
test(cli): improve TestServer/SpammyLogs line count
mafredri Mar 5, 2025
dc30a51
fixup! test(cli): improve TestServer/SpammyLogs line count
mafredri Mar 5, 2025
70b8527
fixup! fixup! test(cli): improve TestServer/SpammyLogs line count
mafredri Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! test(cli): improve TestServer/SpammyLogs line count
  • Loading branch information
@mafredri
mafredri committed Mar 5, 2025
commit dc30a510e93ec206978c7cf69a0a1998c263f733
20 changes: 0 additions & 20 deletions cli/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import (
"runtime"
"strconv"
"strings"
"sync"
"sync/atomic"
"testing"
"time"
Expand Down Expand Up @@ -2349,22 +2348,3 @@ func mockTelemetryServer(t *testing.T) (*url.URL, chan *telemetry.Deployment, ch

return serverURL, deployment, snapshot
}

// syncWriter provides a thread-safe io.ReadWriter implementation
type syncReaderWriter struct {
buf bytes.Buffer
mu sync.Mutex
}

func (w *syncReaderWriter) Write(p []byte) (n int, err error) {
w.mu.Lock()
defer w.mu.Unlock()
return w.buf.Write(p)
}

func (w *syncReaderWriter) Read(p []byte) (n int, err error) {
w.mu.Lock()
defer w.mu.Unlock()

return w.buf.Read(p)
}