chore: remove unused code #16815
Merged
chore: remove unused code #16815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
reviewed
Mar 6, 2025
Comment on lines
-1
to
-9
| /** | ||
| * @file A global error boundary designed to work with React Router. | ||
| * | ||
| * This is not documented well, but because of React Router works, it will | ||
| * automatically intercept any render errors produced in routes, and will | ||
| * "swallow" them, preventing the errors from bubbling up to any error | ||
| * boundaries above the router. The global error boundary must be explicitly | ||
| * bound to a route to work as expected. | ||
| */ |
There was a problem hiding this comment.
@aslilac @brettkolodny Why was this comment deleted?
Up until 2 months ago, we had a broken error boundary for over a year, because the setup doesn't follow standard React and isn't as obvious as it could be
There was a problem hiding this comment.
@aslilac will have to give a definitive answer on this. I mistakenly assumed that the comment was related to the import below it that was deleted which is my bad for not reading it fully.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused variables and imports from several files