Skip to content

Fix: fix Workspace storybook and remove unnecessary fetching from xService #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 24, 2022
Merged

Fix: fix Workspace storybook and remove unnecessary fetching from xService #1682

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e95134a
Make workspace machine ephemeral to limit polling
presleyp May 23, 2022
1ff47a6
Fix Workspace storybook
presleyp May 23, 2022
1b69acf
Lint
presleyp May 23, 2022
abe0eb3
Remove breadcrumb from workspaceXService
presleyp May 23, 2022
c73cf94
Merge branch 'main' into workspace-story/presleyp/1675
presleyp May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Lint
  • Loading branch information
@presleyp
presleyp committed May 23, 2022
commit 1b69acffc45720d03cad9f6a76aa0a4d5528ff8e
2 changes: 1 addition & 1 deletion site/src/components/Workspace/Workspace.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Started.args = {
handleStop: action("stop"),
handleRetry: action("retry"),
resources: [MockWorkspaceResource, MockWorkspaceResource2],
builds: [MockWorkspaceBuild]
builds: [MockWorkspaceBuild],
}

export const Starting = Template.bind({})
Expand Down
1 change: 0 additions & 1 deletion site/src/components/Workspace/Workspace.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import Typography from "@material-ui/core/Typography"
import React from "react"
import * as TypesGen from "../../api/typesGenerated"
import { MONOSPACE_FONT_FAMILY } from "../../theme/constants"
import { WorkspaceStatus } from "../../util/workspace"
import { BuildsTable } from "../BuildsTable/BuildsTable"
import { Resources } from "../Resources/Resources"
import { Stack } from "../Stack/Stack"
Expand Down
2 changes: 1 addition & 1 deletion site/src/components/WorkspaceActions/WorkspaceActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export const WorkspaceActions: React.FC<WorkspaceActionsProps> = ({
handleUpdate,
}) => {
const styles = useStyles()
const workspaceStatus = getWorkspaceStatus(workspace?.latest_build)
const workspaceStatus = getWorkspaceStatus(workspace.latest_build)

return (
<Stack direction="row" spacing={1}>
Expand Down