Skip to content

chore: set default requests/limits in helm chart #16844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 22, 2025
Merged

chore: set default requests/limits in helm chart #16844

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dfbddd6
helm: set default requests/limits
ericpaulsen Mar 7, 2025
323ebd4
conditional logic for default resource values
ericpaulsen Mar 11, 2025
c3327d3
helm: add test cases for custom resource limits and requests
ericpaulsen Mar 17, 2025
2376d54
add test cases for provisioner chart
ericpaulsen Mar 18, 2025
a7609ab
Merge branch 'main' into default-reqs-limits
ericpaulsen Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
helm: set default requests/limits
  • Loading branch information
@ericpaulsen
ericpaulsen committed Mar 7, 2025
commit dfbddd637f8d8c2282cdd2959b71e4b02d10c01f
8 changes: 7 additions & 1 deletion helm/coder/tests/testdata/auto_access_url_1.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,13 @@ spec:
path: /healthz
port: http
scheme: HTTP
resources: {}
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: null
Expand Down
8 changes: 7 additions & 1 deletion helm/coder/tests/testdata/auto_access_url_1_coder.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,13 @@ spec:
path: /healthz
port: http
scheme: HTTP
resources: {}
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: null
Expand Down
8 changes: 7 additions & 1 deletion helm/coder/tests/testdata/auto_access_url_2.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,13 @@ spec:
path: /healthz
port: http
scheme: HTTP
resources: {}
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: null
Expand Down
8 changes: 7 additions & 1 deletion helm/coder/tests/testdata/auto_access_url_2_coder.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,13 @@ spec:
path: /healthz
port: http
scheme: HTTP
resources: {}
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: null
Expand Down
8 changes: 7 additions & 1 deletion helm/coder/tests/testdata/auto_access_url_3.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,13 @@ spec:
path: /healthz
port: http
scheme: HTTP
resources: {}
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: null
Expand Down
8 changes: 7 additions & 1 deletion helm/coder/tests/testdata/auto_access_url_3_coder.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,13 @@ spec:
path: /healthz
port: http
scheme: HTTP
resources: {}
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: null
Expand Down
8 changes: 7 additions & 1 deletion helm/coder/tests/testdata/command.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,13 @@ spec:
path: /healthz
port: http
scheme: HTTP
resources: {}
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: null
Expand Down
8 changes: 7 additions & 1 deletion helm/coder/tests/testdata/command_args.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,13 @@ spec:
path: /healthz
port: http
scheme: HTTP
resources: {}
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: null
Expand Down
8 changes: 7 additions & 1 deletion helm/coder/tests/testdata/command_args_coder.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,13 @@ spec:
path: /healthz
port: http
scheme: HTTP
resources: {}
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: null
Expand Down
8 changes: 7 additions & 1 deletion helm/coder/tests/testdata/command_coder.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,13 @@ spec:
path: /healthz
port: http
scheme: HTTP
resources: {}
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: null
Expand Down
8 changes: 7 additions & 1 deletion helm/coder/tests/testdata/default_values.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,13 @@ spec:
path: /healthz
port: http
scheme: HTTP
resources: {}
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: null
Expand Down
8 changes: 7 additions & 1 deletion helm/coder/tests/testdata/default_values_coder.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,13 @@ spec:
path: /healthz
port: http
scheme: HTTP
resources: {}
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: null
Expand Down
8 changes: 7 additions & 1 deletion helm/coder/tests/testdata/env_from.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,13 @@ spec:
path: /healthz
port: http
scheme: HTTP
resources: {}
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: null
Expand Down
8 changes: 7 additions & 1 deletion helm/coder/tests/testdata/env_from_coder.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,13 @@ spec:
path: /healthz
port: http
scheme: HTTP
resources: {}
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: null
Expand Down
8 changes: 7 additions & 1 deletion helm/coder/tests/testdata/extra_templates.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,13 @@ spec:
path: /healthz
port: http
scheme: HTTP
resources: {}
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: null
Expand Down
8 changes: 7 additions & 1 deletion helm/coder/tests/testdata/extra_templates_coder.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,13 @@ spec:
path: /healthz
port: http
scheme: HTTP
resources: {}
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: null
Expand Down
8 changes: 7 additions & 1 deletion helm/coder/tests/testdata/labels_annotations.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,13 @@ spec:
path: /healthz
port: http
scheme: HTTP
resources: {}
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: null
Expand Down
8 changes: 7 additions & 1 deletion helm/coder/tests/testdata/labels_annotations_coder.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,13 @@ spec:
path: /healthz
port: http
scheme: HTTP
resources: {}
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: null
Expand Down
8 changes: 7 additions & 1 deletion helm/coder/tests/testdata/prometheus.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,13 @@ spec:
path: /healthz
port: http
scheme: HTTP
resources: {}
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: null
Expand Down
8 changes: 7 additions & 1 deletion helm/coder/tests/testdata/prometheus_coder.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,13 @@ spec:
path: /healthz
port: http
scheme: HTTP
resources: {}
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: null
Expand Down
8 changes: 7 additions & 1 deletion helm/coder/tests/testdata/provisionerd_psk.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,13 @@ spec:
path: /healthz
port: http
scheme: HTTP
resources: {}
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: null
Expand Down
8 changes: 7 additions & 1 deletion helm/coder/tests/testdata/provisionerd_psk_coder.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,13 @@ spec:
path: /healthz
port: http
scheme: HTTP
resources: {}
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: null
Expand Down
8 changes: 7 additions & 1 deletion helm/coder/tests/testdata/sa.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,13 @@ spec:
path: /healthz
port: http
scheme: HTTP
resources: {}
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: null
Expand Down
8 changes: 7 additions & 1 deletion helm/coder/tests/testdata/sa_coder.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,13 @@ spec:
path: /healthz
port: http
scheme: HTTP
resources: {}
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: null
Expand Down
8 changes: 7 additions & 1 deletion helm/coder/tests/testdata/sa_disabled.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,13 @@ spec:
path: /healthz
port: http
scheme: HTTP
resources: {}
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: null
Expand Down
8 changes: 7 additions & 1 deletion helm/coder/tests/testdata/sa_disabled_coder.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,13 @@ spec:
path: /healthz
port: http
scheme: HTTP
resources: {}
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: null
Expand Down
Loading
Loading