chore(dogfood): include multiple templates under dogfood/ #16846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
commented
Mar 7, 2025
deansheather
reviewed
Mar 8, 2025
There was a problem hiding this comment.
Could this just be a single coderd provider terraform file instead at dogfood/main.tf, with the actual template terraform things in dogfood/coder and dogfood/coder-envbuilder (no contents dirs)
Doesn't seem like we get much gain from having them be two separate apply operations since the coderd provider should support multiple templates
|
Dean beat me to it! I think this should just be a seperate resource in the same file, instead of two files. |
f81e490 to
fbb1271
Compare
ThomasK33
reviewed
Mar 10, 2025
matifali
reviewed
Mar 10, 2025
148f59c to
d49f813
Compare
ThomasK33
approved these changes
Mar 11, 2025
800c96b to
6f9c950
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an alternative dogfood template that has long-since required manual updating. Bringing this under the auspices of
terraform-provider-coderd. This will also make it easier to add more templates underdogfood/in the future.As part of this, I moved the existing template under
dogfood/coder. I think I got all of the references to it, but there's a non-zero chance I missed something.dogfood/contentstodogfood/coder.coder-envbuildertodogfood/coder-envbuilder.dogfood/main.tfto pushcoder-envbuildertemplate.data.coderd_organization.default.id.