Skip to content

test: skip tests affected by daylight savings issues #16857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2025
Merged

test: skip tests affected by daylight savings issues #16857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6283ed
skip: daylight savings issues
mtojek Mar 10, 2025
39a4c5c
fix
mtojek Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions coderd/database/querier_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2802,6 +2802,7 @@ func TestGroupRemovalTrigger(t *testing.T) {

func TestGetUserStatusCounts(t *testing.T) {
t.Parallel()
t.Skip("https://github.com/coder/internal/issues/464")

if !dbtestutil.WillUsePostgres() {
t.SkipNow()
Expand Down Expand Up @@ -3301,6 +3302,7 @@ func TestGetUserStatusCounts(t *testing.T) {

t.Run("User deleted during query range", func(t *testing.T) {
t.Parallel()

db, _ := dbtestutil.NewDB(t)
ctx := testutil.Context(t, testutil.WaitShort)

Expand Down
3 changes: 2 additions & 1 deletion coderd/insights_internal_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,14 +226,15 @@ func Test_parseInsightsInterval_week(t *testing.T) {
},
wantOk: true,
},
/* FIXME: daylight savings issue
{
name: "6 days are acceptable",
args: args{
startTime: sixDaysAgo.Format(layout),
endTime: stripTime(thisHour).Format(layout),
},
wantOk: true,
},
},*/
{
name: "Shorter than a full week",
args: args{
Expand Down
Loading