feat: add provisioner jobs into the UI #16867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslilac
previously requested changes
Mar 10, 2025
site/src/pages/OrganizationSettingsPage/OrganizationProvisionerJobsPage/JobRow.stories.tsx
Show resolved
Hide resolved
site/src/pages/OrganizationSettingsPage/OrganizationProvisionerJobsPage/JobRow.stories.tsx
Outdated
Show resolved
Hide resolved
site/src/pages/OrganizationSettingsPage/OrganizationProvisionerJobsPage/JobRow.tsx
Outdated
Show resolved
Hide resolved
...tionSettingsPage/OrganizationProvisionerJobsPage/OrganizationProvisionerJobsPage.stories.tsx
Outdated
Show resolved
Hide resolved
|
@aslilac I just left open the discussions about testing and injection, but let me know if they are required for approval. I have no strong opinions on that. |
|
yeah, I feel pretty strongly that escape hatches in the code purely for testing just dilute the value of testing in the first place and make the code harder to understand, especially the |
|
@aslilac I think it is done ✅ |
mtojek
approved these changes
Mar 14, 2025
There was one pending request that I was made and Marcin's reviewed to unblock the merge.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #15192.