chore: hide workspace creation UI for users without permission #16871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
03acbe3 to
124bf93
Compare
aslilac
reviewed
Mar 27, 2025
There was a problem hiding this comment.
maybe we should move the check I mentioned into modules/permissions so that it's more visible. maybe modules/permissions/workspaces.ts?
I definitely think we should keep this it's own thing, rather than tying to the organizationPermissions query. other than that it all looks good!
Comment on lines
118
to
125
| createWorkspaces: { | ||
| object: { | ||
| resource_type: "workspace", | ||
| organization_id: organizationId, | ||
| owner_id: "*", | ||
| }, | ||
| action: "create", | ||
| }, |
There was a problem hiding this comment.
this isn't really related to the rest of the permissions in this query.
we have a query in pages/CreateWorkspacePage/permissions.ts that could be used for this already (it's the exact same permission check, just by itself)
There was a problem hiding this comment.
moved to modules/permissions/workspaces.ts
363e6bb to
6544543
Compare
636bf9c to
3ecc9d9
Compare
aslilac
approved these changes
Apr 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves coder/internal#426