Skip to content

chore: migrate settings page tables from mui to shadcn #16896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 13, 2025
+246 −247
Merged

chore: migrate settings page tables from mui to shadcn #16896

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e2cdf22
chore: migrate to shadcn table
jaaydenh Mar 12, 2025
eb79b33
chore: migrate to shadcn table
jaaydenh Mar 12, 2025
21f7715
fix: use tablehead
jaaydenh Mar 12, 2025
bd5761a
chore: update groups page table to shadcn
jaaydenh Mar 12, 2025
ecb2f3c
chore: update users page table to shadcn
jaaydenh Mar 12, 2025
5b10082
chore: cleanup
jaaydenh Mar 12, 2025
a442ab3
fix: add table height
jaaydenh Mar 13, 2025
6ae5b0f
fix: fix test
jaaydenh Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: fix test
  • Loading branch information
@jaaydenh
jaaydenh committed Mar 13, 2025
commit 6ae5b0f0e01b724b48e3049ac4138181e0760961
9 changes: 5 additions & 4 deletions site/e2e/tests/organizationGroups.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,9 @@ test("change quota settings", async ({ page }) => {
// Go to settings
await login(page, orgUserAdmin);
await page.goto(`/organizations/${org.name}/groups/${group.name}`);
await page.getByRole("button", { name: "Settings", exact: true }).click();
expectUrl(page).toHavePathName(

await page.getByRole("link", { name: "Settings", exact: true }).click();
await expectUrl(page).toHavePathName(
`/organizations/${org.name}/groups/${group.name}/settings`,
);

Expand All @@ -115,11 +116,11 @@ test("change quota settings", async ({ page }) => {
await page.getByRole("button", { name: /save/i }).click();

// We should get sent back to the group page afterwards
expectUrl(page).toHavePathName(
await expectUrl(page).toHavePathName(
`/organizations/${org.name}/groups/${group.name}`,
);

// ...and that setting should persist if we go back
await page.getByRole("button", { name: "Settings", exact: true }).click();
await page.getByRole("link", { name: "Settings", exact: true }).click();
await expect(page.getByLabel("Quota Allowance")).toHaveValue("100");
});
Loading