Skip to content

feat: implement notification inbox system #16901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat: implement notification inbox system #16901

wants to merge 1 commit into from

Conversation

kylecarbs
Copy link
Member

Summary

  • Adds API methods for getting notifications and marking them as read
  • Adds TypeScript types for the notification inbox API
  • Updates notification components to use the official API types
  • Integrates NotificationsInbox component into the navbar UI

Test plan

  • Verify that the notification inbox appears in the navbar next to the deployment dropdown
  • Check that notifications load and display correctly
  • Test marking a notification as read
  • Test marking all notifications as read
  • Verify the settings link works

Closes #16804

🤖 Generated with Claude Code

feat: implement notification inbox system
380bf63 
- Add API methods for getting notifications and marking them as read
- Add TypeScript types for the notification inbox API
- Update notification components to use the official API types
- Integrate NotificationsInbox component into the navbar

Closes #16804

🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions GitHub Actions
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

Coder User seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@mtojek mtojek self-requested a review March 13, 2025 08:08
mtojek
mtojek reviewed Mar 13, 2025
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BrunoQuaresma did you open the PR or Kyle?

@kylecarbs
Copy link
Member Author

@mtojek this was just me testing heh. We can close.

@kylecarbs kylecarbs closed this Mar 13, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek left review comments

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add navbar property to CODER_SUPPORT_LINKS
2 participants
@kylecarbs @mtojek