Skip to content

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented May 23, 2022

This PR updates the CONTRIBUTING.md with some frontend code conventions and best practices.

Rationale

I know we have a lot more mentioned in Notion but I figured, we should keep it approachable and add more as needed down the road.

Fixes #944

@jsjoeio jsjoeio self-assigned this May 23, 2022
@jsjoeio jsjoeio added the docs Area: coder.com/docs label May 23, 2022
@jsjoeio jsjoeio marked this pull request as ready for review May 23, 2022 21:41
@jsjoeio jsjoeio requested a review from a team May 23, 2022 21:41
@greyscaled greyscaled requested a review from presleyp May 23, 2022 21:44
@jsjoeio jsjoeio enabled auto-merge (squash) May 23, 2022 21:45
Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

jsjoeio and others added 3 commits May 24, 2022 15:21
@jsjoeio jsjoeio force-pushed the 944-update-contribution-guidelines branch from 5c9f138 to 69397f0 Compare May 24, 2022 15:21
@jsjoeio jsjoeio merged commit 61ffd03 into main May 24, 2022
@jsjoeio jsjoeio deleted the 944-update-contribution-guidelines branch May 24, 2022 15:30
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
* docs(contributing): add subheading backend under styling

* docs: add styling for frontend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Area: coder.com/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Contribution Guidelines
4 participants