Skip to content

chore: add prebuilds system user #16916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Mar 25, 2025
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
300e80f
add prebuilds system user database changes and associated changes
SasSwart Mar 12, 2025
b788237
optionally prevent system users from counting to user count
dannykopping Mar 13, 2025
8122595
appease the linter
dannykopping Mar 13, 2025
bfb7c28
add unit test for system user behaviour
dannykopping Mar 13, 2025
6639167
reverting RBAC changes; not relevant here
dannykopping Mar 13, 2025
769ae1d
removing unnecessary changes
dannykopping Mar 13, 2025
e7e9c27
exclude system user db tests from non-linux OSs
dannykopping Mar 13, 2025
3936047
Rename prebuild system user reference
SasSwart Mar 17, 2025
8bdcafb
ensure that users.IsSystem is not nullable
SasSwart Mar 17, 2025
324fde2
Fixes
dannykopping Mar 17, 2025
81d9dfa
Merge remote-tracking branch 'origin/main' into prebuilds-system-user
SasSwart Mar 18, 2025
896c881
renumber migrations
SasSwart Mar 18, 2025
de4fb8a
ensure that system users are filtered and returned consistently
SasSwart Mar 19, 2025
2751d5b
make -B lint
SasSwart Mar 19, 2025
1042c39
rewrite prebuilds system user tests in our usual style
SasSwart Mar 19, 2025
f9e9d11
add support for prebuilds user to dbmem
SasSwart Mar 19, 2025
7492965
appease the linter
SasSwart Mar 19, 2025
29e2020
add support for the prebuilds system user to dbmem
SasSwart Mar 19, 2025
8c51585
linter
SasSwart Mar 19, 2025
cdc5c71
fix dbmem tests
SasSwart Mar 19, 2025
0d4813a
remove restriction on modifying system users for now
SasSwart Mar 19, 2025
95d70a3
remove system user index
SasSwart Mar 20, 2025
8f1d71c
Merge remote-tracking branch 'origin/main' into prebuilds-system-user
SasSwart Mar 24, 2025
7e009e5
invert tests that check for system user update protection
SasSwart Mar 24, 2025
addd7c6
lint
SasSwart Mar 24, 2025
7a4ef24
Allow TestUpdateSystemUser to run against dbmem
SasSwart Mar 24, 2025
f30ce72
Merge remote-tracking branch 'origin/main' into prebuilds-system-user
SasSwart Mar 25, 2025
5f0ae5e
Renumber migrations
SasSwart Mar 25, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
appease the linter
  • Loading branch information
SasSwart committed Mar 19, 2025
commit 7492965413f8e82b51b991f2bb9b53a11772ae5f
1 change: 0 additions & 1 deletion coderd/database/querier_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1421,7 +1421,6 @@ func TestGetUsers_IncludeSystem(t *testing.T) {
require.Equal(t, tt.wantSystemUser, len(users) == 2, "should have 2 users when including system user, 1 otherwise")
})
}

}

func TestUpdateSystemUser(t *testing.T) {
Expand Down