Skip to content

Improve CLI logout flow #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 24, 2022
Merged

Improve CLI logout flow #1692

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
abff3c8
Improve CLI logout flow
AbhineetJain May 23, 2022
a7775b0
Fix lint error
AbhineetJain May 23, 2022
0584479
Make notLoggedInMessage a const
AbhineetJain May 23, 2022
33adc09
successful logout with a msg when cfg files are absent
AbhineetJain May 23, 2022
06142b0
use require, os.remove, show only one message, add prompt
AbhineetJain May 24, 2022
5f01dfd
Merge branch 'main' into abhineetjain/improve-logout
AbhineetJain May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint error
  • Loading branch information
@AbhineetJain
AbhineetJain committed May 23, 2022
commit a7775b02ac6f21012cf22a19d4458224dd51535d
4 changes: 2 additions & 2 deletions cli/logout_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ func login(t *testing.T) config.Root {
coderdtest.CreateFirstUser(t, client)

doneChan := make(chan struct{})
root, config := clitest.New(t, "login", "--force-tty", client.URL.String(), "--no-open")
root, cfg := clitest.New(t, "login", "--force-tty", client.URL.String(), "--no-open")
pty := ptytest.New(t)
root.SetIn(pty.Input())
root.SetOut(pty.Output())
Expand All @@ -77,5 +77,5 @@ func login(t *testing.T) config.Root {
pty.ExpectMatch("Welcome to Coder")
<-doneChan

return config
return cfg
}