Skip to content

docs: document definition of workspace activity #16941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2025

Conversation

EdwardAngert
Copy link
Contributor

@EdwardAngert EdwardAngert commented Mar 14, 2025

closes: #16884

aligns the documentation with what users see when they adjust settings and uses the notion discussion as a reference. This PR reflects current behavior from what I can tell.

preview

@EdwardAngert EdwardAngert added the docs Area: coder.com/docs label Mar 14, 2025
@EdwardAngert EdwardAngert self-assigned this Mar 14, 2025
@EdwardAngert EdwardAngert changed the title docs: Document definition of workspace activity docs: document definition of workspace activity Mar 14, 2025
@EdwardAngert EdwardAngert requested a review from ssncoder March 14, 2025 20:24
for your workspace.

### What counts as workspace activity?

A workspace is considered "active" when Coder detects one or more active sessions with your workspace. Coder specifically tracks these session types:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to add something like "saving changes to code counts as activity," which I think is true, but it seems like that might be oversimplified. Is there a good single-(noncomplex)-sentence summary we can add here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be really nice but as far as I understand our activity tracking is based on network usage and doesn't count file activity.
I am not sure who is the right person to confirm this.
Maybe @deansheather?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@f0ssel I've realized I don't know what state we left things in re: the workspace activity refactor. Can you look at this section and comment whether it's accurate regarding the code as it exists today?

Copy link
Contributor

@spikecurtis spikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like @f0ssel to double-check the conditions under which we bump the autostop time due to activity. Doesn't have to block the merge, as we can fix it up in a second PR.

@spikecurtis spikecurtis requested a review from f0ssel March 17, 2025 10:46
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Spike mentioned, we need to square this with the workspace activity refactor.

But as far as I can tell, the updated documentation corresponds with what we want to be true.

@EdwardAngert
Copy link
Contributor Author

merging this as-is and we'll come back to it with more edits with the workspace activity refactor

@EdwardAngert EdwardAngert merged commit bbe7dac into main Mar 21, 2025
32 checks passed
@EdwardAngert EdwardAngert deleted the 16884-define-activity branch March 21, 2025 14:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Area: coder.com/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document definition of activity for workspace deadline bump
4 participants