fix: fix audit log search #16944
Merged
fix: fix audit log search #16944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cherry-pick release/2.20 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this recently added early return means that any "invalid" query (including a partial one while typing) will entirely crash the audit logs page. the parsing logic on the backend is incredibly strict currently, and so trying to type anything into the search bar will break the entire page.
there is logic in the
AuditPageViewcomponent that is supposed to render this error value, and that will do so without removing the search bar from the page. we can just let that code do what it's supposed to, and don't need to do any handling here.