feat: persist prebuild definitions on template import #16951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
appeasing linter Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
70ecdcc to
7e062e2
Compare
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
appeasing linter Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
7e062e2 to
51773ec
Compare
12 tasks
mtojek
reviewed
Mar 28, 2025
| InvalidateAfterSecs: sql.NullInt32{ | ||
| Int32: 0, | ||
| Valid: false, | ||
| }, // TODO: implement cache invalidation |
There was a problem hiding this comment.
Re TODO: perhaps create an issue for that and link it here
mtojek
reviewed
Mar 28, 2025
dannykopping
reviewed
Apr 7, 2025
| @@ -182,7 +182,6 @@ func TestDBAuthzRecursive(t *testing.T) { | |||
| method.Name == "PGLocks" { | |||
| continue | |||
| } | |||
| // Log the name of the last method, so if there is a panic, it is | |||
| @@ -883,10 +884,24 @@ func ConvertState(ctx context.Context, modules []*tfjson.StateModule, rawGraph s | |||
| ) | |||
| } | |||
|
|
|||
| if len(preset.Prebuilds) != 1 { | |||
There was a problem hiding this comment.
Will this not warn incorrectly when there are no prebuilds defined at all (which is perfectly valid)?
Shouldn't this be len(preset.Prebuilds) > 1?
| @@ -2,7 +2,7 @@ terraform { | |||
| required_providers { | |||
| coder = { | |||
| source = "coder/coder" | |||
| version = "2.1.3" | |||
| version = "2.3.0-pre2" | |||
There was a problem hiding this comment.
Now that coder/terraform-provider-coder#373 is merged we should cut a release and reference it here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows provisioners to recognise and report prebuild definitions to the coder control plane. It also allows the coder control plane to then persist these to its store.
closes coder/internal#507