feat(coderd): add mark-all-as-read endpoint for inbox notifications #16976
Conversation
coderd/database/dbmem/dbmem.go
Outdated
| q.inboxNotifications[idx].ReadAt = sql.NullTime{ | ||
| Time: dbtime.Now(), | ||
| Valid: true, |
There was a problem hiding this comment.
Shouldn't you use ReadAt from arg?
There was a problem hiding this comment.
Not sure if you have a use case in mind - having it as an arg would mean the user can set the notification as read 'in the past'.
There was a problem hiding this comment.
Take a look at coderd/inboxnotifications.go:
err := api.Database.MarkAllInboxNotificationsAsRead(ctx, database.MarkAllInboxNotificationsAsReadParams{
UserID: apikey.UserID,
ReadAt: sql.NullTime{Time: dbtime.Now(), Valid: true},
})
This is precisely how you're calling it. You need to go one way or another:
- Remove
ReadAtfrom the arg. - Modify dbmem to take
dbtime.Now()from coderd.
Let me know if this is clear. I can hop on zoom to explain.
There was a problem hiding this comment.
Ok sorry - I understood and indeed make sense :D Should be better - otherwise please tell me. 🙏
|
@defelmnq Feel free to re-request reviews when the PR is ready for another look 👍 . I'll watch email notifications. |
|
Should be all good for another review ✅ |
coderd/database/dbmem/dbmem.go
Outdated
| q.inboxNotifications[idx].ReadAt = sql.NullTime{ | ||
| Time: dbtime.Now(), | ||
| Valid: true, |
There was a problem hiding this comment.
Take a look at coderd/inboxnotifications.go:
err := api.Database.MarkAllInboxNotificationsAsRead(ctx, database.MarkAllInboxNotificationsAsReadParams{
UserID: apikey.UserID,
ReadAt: sql.NullTime{Time: dbtime.Now(), Valid: true},
})
This is precisely how you're calling it. You need to go one way or another:
- Remove
ReadAtfrom the arg. - Modify dbmem to take
dbtime.Now()from coderd.
Let me know if this is clear. I can hop on zoom to explain.
Resolve this issue
Add a mark-all-as-read endpoint which is marking as read all notifications that are not read for the authenticated user.
Also adds the DB logic.