Skip to content

feat: add notifications widget in the navbar #16983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 18, 2025
Merged

feat: add notifications widget in the navbar #16983

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c182295
feat: add notifications widget in the navbar
BrunoQuaresma Mar 18, 2025
a696bd7
FMT
BrunoQuaresma Mar 18, 2025
328854d
Merge branch 'main' of https://github.com/coder/coder into bq/notific…
BrunoQuaresma Mar 18, 2025
281dadf
Apply review comments and fix storybook tests
BrunoQuaresma Mar 18, 2025
4d0f010
Fix lint
BrunoQuaresma Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix lint
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Mar 18, 2025
commit 4d0f01005de7b9cbc68682fd6fbc809ca414b59c
3 changes: 1 addition & 2 deletions site/src/modules/notifications/NotificationsInbox/NotificationsInbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ import type {
UpdateInboxNotificationReadStatusResponse,
} from "api/typesGenerated";
import { displayError } from "components/GlobalSnackbar/utils";
import { useEffectEvent } from "hooks/hookPolyfills";
import { type FC, useEffect, useRef } from "react";
import { useMutation, useQuery, useQueryClient } from "react-query";
import { InboxPopover } from "./InboxPopover";
import { useEffectEvent } from "hooks/hookPolyfills";

const NOTIFICATIONS_QUERY_KEY = ["notifications"];

Expand Down Expand Up @@ -79,7 +79,6 @@ export const NotificationsInbox: FC<NotificationsInboxProps> = ({
mutationFn: markAllAsRead,
onSuccess: () => {
updateNotificationsCache((prev) => {
console.log("PREV", prev);
return {
unread_count: 0,
notifications: prev.notifications.map((n) => ({
Expand Down
Loading