Skip to content

fix: resolve flakey inbox tests #17010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 19, 2025
Merged

fix: resolve flakey inbox tests #17010

merged 2 commits into from
Mar 19, 2025

Conversation

DanielleMaywood
Copy link
Contributor

@DanielleMaywood DanielleMaywood commented Mar 19, 2025 •
edited
Loading

Fix flakey Coder Inbox tests by opening database subscriber before accepting the web socket request.

@DanielleMaywood DanielleMaywood changed the title chore: add error checking for flaky tests fix: flakey inbox tests Mar 19, 2025
@DanielleMaywood DanielleMaywood changed the title fix: flakey inbox tests fix: resolve flakey inbox tests Mar 19, 2025
defelmnq
defelmnq approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@defelmnq defelmnq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@DanielleMaywood DanielleMaywood merged commit b39477c into main Mar 19, 2025
36 checks passed
@DanielleMaywood DanielleMaywood deleted the dm-add-error-check branch March 19, 2025 22:06
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@defelmnq defelmnq defelmnq approved these changes

Assignees

@DanielleMaywood DanielleMaywood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielleMaywood @defelmnq