Skip to content

feat: add API endpoint for retrieving OIDC logout URL #17015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

feat: add API endpoint for retrieving OIDC logout URL #17015

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6bffc22
feat: support OIDC logout with Coder logout
esifea Mar 20, 2025
39a35ef
feat(coderd): add OIDCLogoutResponse
esifea Mar 20, 2025
c2c3ddf
refactor(coderd): apply codersdk.OIDCLogoutResponse at success
esifea Mar 20, 2025
c11ee84
chore(site): apply fmt
esifea Mar 20, 2025
c0bbf71
chore: add auto generated files
esifea Mar 20, 2025
2063e6e
chore: fix docs
esifea Mar 25, 2025
f2f487c
Update codersdk/deployment.go
esifea Apr 3, 2025
2315817
feat(coderd): implement OIDC revocation with RP initiated logout
esifea Apr 3, 2025
99c1e59
chore: add auto generated files
esifea Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: add auto generated files
  • Loading branch information
@esifea
esifea committed Apr 3, 2025
commit 99c1e59e015c8f5a59e2195f11f3589737a01734
5 changes: 1 addition & 4 deletions cli/testdata/coder_server_--help.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,10 +592,7 @@ OIDC OPTIONS:
--oidc-username-field string, $CODER_OIDC_USERNAME_FIELD (default: preferred_username)
OIDC claim field to use as the username.

--logout-endpoint string, $CODER_OIDC_LOGOUT_ENDPOINT
OIDC endpoint for logout.

--logout-redirect-uri string, $CODER_OIDC_LOGOUT_URI
--oidc-logout-redirect-uri string, $CODER_OIDC_LOGOUT_URI
OIDC redirect URI after logout.

--oidc-sign-in-text string, $CODER_OIDC_SIGN_IN_TEXT (default: OpenID Connect)
Expand Down
3 changes: 0 additions & 3 deletions cli/testdata/server-config.yaml.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,9 +401,6 @@ oidc:
# an insecure OIDC configuration. It is not recommended to use this flag.
# (default: <unset>, type: bool)
dangerousSkipIssuerChecks: false
# OIDC endpoint for logout.
# (default: <unset>, type: string)
logoutEndpoint: ""
# OIDC redirect URI after logout.
# (default: <unset>, type: string)
logoutRedirectURI: ""
Expand Down
12 changes: 1 addition & 11 deletions docs/reference/cli/server.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions enterprise/cli/testdata/coder_server_--help.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,10 +593,7 @@ OIDC OPTIONS:
--oidc-username-field string, $CODER_OIDC_USERNAME_FIELD (default: preferred_username)
OIDC claim field to use as the username.

--logout-endpoint string, $CODER_OIDC_LOGOUT_ENDPOINT
OIDC endpoint for logout.

--logout-redirect-uri string, $CODER_OIDC_LOGOUT_URI
--oidc-logout-redirect-uri string, $CODER_OIDC_LOGOUT_URI
OIDC redirect URI after logout.

--oidc-sign-in-text string, $CODER_OIDC_SIGN_IN_TEXT (default: OpenID Connect)
Expand Down