Skip to content

feat: add user_tailnet_connections to telemetry #17018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

feat: add user_tailnet_connections to telemetry #17018

merged 1 commit into from
Mar 20, 2025

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Mar 20, 2025 •
edited
Loading

Summary

  • Add UserTailnetConnection struct to track desktop client connections
  • Add new field to Snapshot struct for telemetry
  • Data collection to be implemented in a future PR

relates to coder/nexus#197

@spikecurtis
feat: add user_tailnet_connections to telemetry
8d6aedf 
Add UserTailnetConnection struct and field to Snapshot for tracking desktop connections.

Data collection will be implemented in a future PR.
@spikecurtis spikecurtis marked this pull request as ready for review March 20, 2025 10:18
@coder coder deleted a comment from deansheather Mar 20, 2025
@hugodutka
Copy link
Contributor

@deansheather I somehow deleted your comment - I'm not even sure how that happened. I didn't mean to. Sorry!

@spikecurtis
Copy link
Contributor Author

I think this comment was deleted by mistake. @deansheather

We should probably add a unique ID for the event, can just be a uuid.New()

I feel like connected_at, user_id, peer_id should be plenty unique. It would be wild to get multiple connections using the same peer token (only way to get the same PeerID) at exactly the same instant, and the extra column could really add up in terms of space at the scale of telemetry.

@spikecurtis spikecurtis merged commit 7d60186 into main Mar 20, 2025
36 checks passed
@spikecurtis spikecurtis deleted the spike/coder-desktop-telemetry branch March 20, 2025 13:04
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

@hugodutka hugodutka hugodutka approved these changes

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spikecurtis @hugodutka @deansheather