feat: filter users by github user id in the users list CLI command #17029
+124
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
approved these changes
Mar 21, 2025
| p.Errors = append(p.Errors, codersdk.ValidationError{ | ||
| Field: queryParam, | ||
| Detail: fmt.Sprintf("Query param %q must be a valid 64-bit integer: %s", queryParam, err.Error()), | ||
| }) |
There was a problem hiding this comment.
suggestion: explicitly return the zero value here
Comment on lines
+227
to
+229
| WHEN @github_com_user_id :: bigint != 0 THEN | ||
| github_com_user_id = @github_com_user_id | ||
| ELSE true |
There was a problem hiding this comment.
I don't think this is worth blocking on, but the comment for this column mentions:
At time of implementation, this is used to check if the user has starred the Coder repository.
It may be worth updating this comment in a follow-up now that it's becoming more of a load-bearing number.
f29590e to
d08dd3b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
--github-user-idoption tocoder users list, which makes the command only return users with a matching GitHub user id. This will enable https://github.com/coder/start-workspace-action to find a Coder user that corresponds to a GitHub user requesting to start a workspace.