Skip to content

feat(cli): add open app <workspace> <app-slug> command #17032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 21, 2025
Merged

feat(cli): add open app <workspace> <app-slug> command #17032

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
afbe048
feat(cli): add open app <workspace> <app-slug> command
johnstcn Mar 20, 2025
56fc1ce
Update cli/open.go
johnstcn Mar 21, 2025
f94b6fe
address PR comments
johnstcn Mar 21, 2025
c7a942b
make gen
johnstcn Mar 21, 2025
598dec6
sort ALL the things
johnstcn Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update cli/open.go
  • Loading branch information
@johnstcn
johnstcn authored Mar 21, 2025
commit 56fc1ce1055d1c0f1497b113a195a68afc26bcd0
5 changes: 2 additions & 3 deletions cli/open.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,8 @@ func (r *RootCmd) openApp() *serpent.Command {
ctx, cancel := context.WithCancel(inv.Context())
defer cancel()

// Check if we're inside a workspace, and especially inside _this_
// workspace so we can perform path resolution/expansion. Generally,
// we know that if we're inside a workspace, `open` can't be used.
// Check if we're inside a workspace. Generally, we know
// that if we're inside a workspace, `open` can't be used.
insideAWorkspace := inv.Environ.Get("CODER") == "true"

// Fetch the preferred region.
Expand Down
Loading