Skip to content

feat(coderd): add format option to inbox notifications watch endpoint #17034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 21, 2025

Conversation

defelmnq
Copy link
Contributor

@defelmnq defelmnq commented Mar 21, 2025

This PR aims to allow clients to use different format for the title and content of inbox notifications - on the watch endpoint.

This solution will help to have it working and formatted differently on VSCode, WebUI ...
Related to this issue

@defelmnq defelmnq changed the title update doc and remove plaintext format feat(coderd): add format option to inbox notifications watch endpoint Mar 21, 2025
@defelmnq defelmnq marked this pull request as ready for review March 21, 2025 14:27
Copy link
Contributor

@DanielleMaywood DanielleMaywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :shipit:

@defelmnq defelmnq requested a review from mafredri March 21, 2025 15:11
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@defelmnq defelmnq merged commit 82e3773 into main Mar 21, 2025
32 checks passed
@defelmnq defelmnq deleted the inbox-notif/internal-523 branch March 21, 2025 15:41
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants