ci: standardize on go 1.22.12 #17047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslilac
approved these changes
Mar 21, 2025
spikecurtis
requested changes
Mar 24, 2025
1 task
b2a8edc to
d0c9cf8
Compare
johnstcn
commented
Mar 24, 2025
| @@ -2,14 +2,14 @@ FROM rust:slim@sha256:9abf10cc84dfad6ace1b0aae3951dc5200f467c593394288c11db1e17b | |||
| # Install rust helper programs | |||
| # ENV CARGO_NET_GIT_FETCH_WITH_CLI=true | |||
| ENV CARGO_INSTALL_ROOT=/tmp/ | |||
| RUN cargo install exa bat ripgrep typos-cli watchexec-cli && \ | |||
| RUN cargo install typos-cli watchexec-cli && \ | |||
There was a problem hiding this comment.
review: bat was failing to build for me locally, but bat, exa, and ripgrep can now be installed via apt.
johnstcn
commented
Mar 24, 2025
Comment on lines
-68
to
-70
| # go-fuzz for fuzzy testing. they don't publish releases so we rely on latest. | ||
| go install github.com/dvyukov/go-fuzz/go-fuzz@latest && \ | ||
| go install github.com/dvyukov/go-fuzz/go-fuzz-build@latest && \ |
There was a problem hiding this comment.
review: this was failing to build with a tools dependency issue but it doesn't seem to be required since go 1.18?
spikecurtis
approved these changes
Mar 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of Go in our dogfood Dockerfile was seemingly unintentionally bumped in #16894
We need to keep our various Go versions in sync, otherwise things get confusing: