Skip to content

fix(cli): replace $SESSION_TOKEN placeholder for external apps #17048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2025
Merged

fix(cli): replace $SESSION_TOKEN placeholder for external apps #17048

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
248f179
fix(cli): replace $SESSION_TOKEN placeholder for external apps
johnstcn Mar 21, 2025
5e7fc66
i can spel gud
johnstcn Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
i can spel gud
  • Loading branch information
@johnstcn
johnstcn committed Mar 21, 2025
commit 5e7fc661d7b66b4bd7682789b016da28f46ade17
2 changes: 1 addition & 1 deletion cli/open.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,7 @@ func buildAppLinkURL(baseURL *url.URL, workspace codersdk.Workspace, agent coder

// replacePlaceholderExternalSessionTokenString replaces any $SESSION_TOKEN
// strings in the URL with the actual session token.
// This is consistent behaviour with the frontend. See: site/src/modules/resources/AppLink/AppLink.tsx
// This is consistent behavior with the frontend. See: site/src/modules/resources/AppLink/AppLink.tsx
func replacePlaceholderExternalSessionTokenString(client *codersdk.Client, appURL string) string {
if !strings.Contains(appURL, "$SESSION_TOKEN") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only supported format? Not e.g. ${SESSION_TOKEN}?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it's just const magicTokenString = "$SESSION_TOKEN";

return appURL
Expand Down
Loading