Skip to content

chore: use container memory if containerised for oom notifications #17062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 24, 2025
Merged

chore: use container memory if containerised for oom notifications #17062

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
87adb1d
chore: query container memory if available
DanielleMaywood Mar 23, 2025
1e28ae7
chore: fallback to host memory limit
DanielleMaywood Mar 24, 2025
0a96813
chore: add error handling
DanielleMaywood Mar 24, 2025
f1dc9f7
chore: error handling
DanielleMaywood Mar 24, 2025
a2182e1
chore: add tests
DanielleMaywood Mar 24, 2025
1df4073
chore: appease linter
DanielleMaywood Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: add error handling
  • Loading branch information
@DanielleMaywood
DanielleMaywood committed Mar 24, 2025
commit 0a9681318d2de0c4d2d54533297fa8a59ed91bdb
5 changes: 4 additions & 1 deletion agent/agent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -965,7 +965,10 @@
if err != nil {
return xerrors.Errorf("failed to create resources fetcher: %w", err)
}
resourcesFetcher := resourcesmonitor.NewFetcher(statfetcher)
resourcesFetcher, err := resourcesmonitor.NewFetcher(statfetcher)

Check failure on line 968 in agent/agent.go

View workflow job for this annotation

GitHub Actions / gen 

assignment mismatch: 2 variables but resourcesmonitor.NewFetcher returns 1 value

Check failure on line 968 in agent/agent.go

View workflow job for this annotation

GitHub Actions / test-go (ubuntu-latest) 

assignment mismatch: 2 variables but resourcesmonitor.NewFetcher returns 1 value

Check failure on line 968 in agent/agent.go

View workflow job for this annotation

GitHub Actions / test-go-pg (ubuntu-latest) 

assignment mismatch: 2 variables but resourcesmonitor.NewFetcher returns 1 value

Check failure on line 968 in agent/agent.go

View workflow job for this annotation

GitHub Actions / test-go-pg-16 

assignment mismatch: 2 variables but resourcesmonitor.NewFetcher returns 1 value

Check failure on line 968 in agent/agent.go

View workflow job for this annotation

GitHub Actions / test-go-race 

assignment mismatch: 2 variables but resourcesmonitor.NewFetcher returns 1 value

Check failure on line 968 in agent/agent.go

View workflow job for this annotation

GitHub Actions / test-go-race-pg 

assignment mismatch: 2 variables but resourcesmonitor.NewFetcher returns 1 value

Check failure on line 968 in agent/agent.go

View workflow job for this annotation

GitHub Actions / test-e2e 

assignment mismatch: 2 variables but resourcesmonitor.NewFetcher returns 1 value
if err != nil {
return xerrors.Errorf("new resource fetcher: %w", err)
}

resourcesmonitor := resourcesmonitor.NewResourcesMonitor(logger, clk, config, resourcesFetcher, aAPI)
return resourcesmonitor.Start(ctx)
Expand Down
Loading