Skip to content

chore: fix gosec G115 linting issues for Go 1.24.1 update #17084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

sreya
Copy link
Collaborator

@sreya sreya commented Mar 25, 2025

Adds detailed #nosec G115 annotations to resolve gosec linting issues for the Go 1.24.1 upgrade in PR #17035.

This PR adds proper annotations with detailed comments to explain why each integer conversion is safe, which helps the linter understand that these conversions are intentional and the potential overflow risks are handled appropriately.

Part of the work for #17035.

Claude and others added 2 commits March 25, 2025 07:03
Added more detailed #nosec G115 annotations to fix gosec warnings

🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Fix go:build directive spacing in pty_linux.go
- Add bounds checks and #nosec annotations for integer conversions
- Fix comment alignment and formatting
- Address gosec G115 warnings in multiple files

Co-Authored-By: Claude <noreply@anthropic.com>
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


0 out of 2 committers have signed the CLA.
@claude
@user
Claude, User seem not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@sreya sreya closed this Mar 25, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2025
@sreya sreya deleted the sreya/go-1-24-1-lint-fixes branch March 25, 2025 07:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant