Skip to content

fix: add detailed gosec G115 annotations #17085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

sreya
Copy link
Collaborator

@sreya sreya commented Mar 25, 2025

This PR adds more detailed #nosec G115 annotations to fix gosec linting issues in various files. These annotations explain why each integer conversion is safe and how potential overflow is handled.

The changes include:

  • Added explanatory comments for each integer conversion in several files
  • Documented specific cases where overflow is acceptable
  • Added bounds checking context where needed

These changes should resolve the remaining lint issues in #17035.

Added more detailed #nosec G115 annotations to fix gosec warnings

Signed-off-by: sreya <sreya@coder.com>
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


Claude seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@sreya sreya closed this Mar 25, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2025
@sreya sreya deleted the sreya/lint-fixes-new branch March 25, 2025 07:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant