feat: adds device_id, device_os, and coder_desktop_version to telemetry #17086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1a803fe to
dea30ba
Compare
dea30ba to
91f5fba
Compare
johnstcn
approved these changes
Mar 25, 2025
Comment on lines
+2513
to
+2520
| func requireEqualOrBothNil[T any](t testing.TB, a, b *T) { | ||
| t.Helper() | ||
| if a != nil && b != nil { | ||
| require.Equal(t, *a, *b) | ||
| return | ||
| } | ||
| require.Equal(t, a, b) | ||
| } |
There was a problem hiding this comment.
suggestion: potentially useful tesutil candidate?
Merge activity
|
|
👀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Records the Device ID, Device OS and Coder Desktop version to telemetry.
These values are provided by the Coder Desktop client in the StartRequest method of the VPN protocol. We render them as an HTTP header to transmit to Coderd, where they are decoded and added to telemetry.