feat: add name to workspace agent devcontainers #17089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the presence of multiple devcontainers, it would be nice to differentiate them by name. This change inherits the resource name from terraform.
mafredri
commented
Mar 25, 2025
| @@ -195,6 +195,7 @@ message Script { | |||
| message Devcontainer { | |||
| string workspace_folder = 1; | |||
| string config_path = 2; | |||
| string name = 3; | |||
There was a problem hiding this comment.
@spikecurtis Do we need to bump the version again? Or is it fine if this makes it into the release cut?
There was a problem hiding this comment.
One version bump per release is fine.
There was a problem hiding this comment.
IMO we don't need a separate version bump as long as this gets into the release.
johnstcn
approved these changes
Mar 25, 2025
DanielleMaywood
approved these changes
Mar 25, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the presence of multiple devcontainers, it would be nice to
differentiate them by name. This change inherits the resource name from
terraform.
Ref #17076