Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(coderd): add webpush package #17091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(coderd): add webpush package #17091
Changes from all commits
a980379
bc02200
2ecae9d
84e3ace
377eaab
982acef
d82073e
fc59c70
cbff3ca
9e7e1dc
1315a46
85db78c
892388a
e600b7d
eef2038
46f7519
4408090
204ab4a
0535ed6
9f1f4f9
29bba04
46c2cd8
960c5db
aa22161
57d84a9
ef22b35
9a1a605
e8b6083
5331f9c
449f882
e5fd00e
bcf108a
eb7b102
9b5ed09
c06558e
10ac9fb
a114ddb
ca72676
3b1dc70
12808f1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm quite sure I have seen this pattern in other CLI commands:
startBuiltinPostgres - codersdk.PostgresAuth - ConnectToPostgres
we may consider some base pattern for all commands using the database
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep there are a few commands that do this. I'll create a follow-up. (EDIT: coder/internal#541)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just confirming - is there a chance that there will be another testrun operating on this table (flakiness risk?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There shouldn't be. It operates entirely in its own transaction, and each test should be operating on its own database.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: unrelated change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm actually not sure what's causing these changes, but the command to update these golden files is convinced that this is how it should be now.