Skip to content

fix: prevent password reset notifications ending up in coder inbox #17109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

DanielleMaywood
Copy link
Contributor

We do not want password reset notifications to end up in Coder Inbox as this doesn't make much sense. This implements the logic to ensure they are not delivered if the method is Coder Inbox.

In the future we might want to investigate a better solution but for now this works.

We do not want password reset notifications to end up in Coder Inbox as
this doesn't make much sense. This implements the logic to ensure they
are not delivered if the method is Coder Inbox.

In the future we might want to investigate a better solution but for now
this works.
@DanielleMaywood DanielleMaywood marked this pull request as ready for review March 26, 2025 11:06
@DanielleMaywood DanielleMaywood requested a review from mtojek March 26, 2025 11:06
@mtojek mtojek merged commit eaab404 into main Mar 26, 2025
34 checks passed
@mtojek mtojek deleted the dm-filter-password-reset-for-inbox branch March 26, 2025 11:19
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants