Skip to content

feat(cli): push dynamically generated templates with version name #17114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2025
Merged

feat(cli): push dynamically generated templates with version name #17114

merged 1 commit into from
Mar 27, 2025

Conversation

michaelvp411
Copy link
Contributor

@michaelvp411 michaelvp411 commented Mar 26, 2025 •
edited by matifali
Loading

Closes #17031
Updated tempatespush.go

@michaelvp411 michaelvp411 added the cli Area: CLI label Mar 26, 2025
@michaelvp411 michaelvp411 self-assigned this Mar 26, 2025
@michaelvp411 michaelvp411 changed the title Push dynamically generated templates with version name feat: push dynamically generated templates with version name Mar 26, 2025
@matifali
Copy link
Member

@michaelvp411 can you rebase on main?
image
This button should do the job.

@michaelvp411 michaelvp411 force-pushed the mvp-dyamic-templates-fix branch from 9a9fc55 to 14aeb6b Compare March 26, 2025 17:27
@michaelvp411
Copy link
Contributor Author

michaelvp411 commented Mar 26, 2025 •
edited
Loading

Just rebased
@matifali

matifali
matifali reviewed Mar 26, 2025
View reviewed changes
Copy link
Member

@matifali matifali left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look sane to me but I will wait for an engineer's approval to rule out any hidden caveats here.

@matifali matifali changed the title feat: push dynamically generated templates with version name feat(cli): push dynamically generated templates with version name Mar 26, 2025
@michaelvp411 michaelvp411 merged commit 0eec78d into main Mar 27, 2025
33 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali left review comments

@aslilac aslilac aslilac approved these changes

@angrycub angrycub Awaiting requested review from angrycub

@mtojek mtojek Awaiting requested review from mtojek

Assignees

@michaelvp411 michaelvp411

Labels
cli Area: CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Pushing and testing dynamically generated templates fail their first test.
3 participants
@michaelvp411 @matifali @aslilac