feat: split cli roles edit command into create and update commands #17121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslilac
approved these changes
Apr 3, 2025
cli/organizationroles.go
Outdated
| arr := make([]json.RawMessage, 0) | ||
| err = json.Unmarshal(bytes, &arr) | ||
| if err == nil && len(arr) > 0 { | ||
| return xerrors.Errorf("the input appears to be an array, only 1 role can be sent at a time") |
There was a problem hiding this comment.
Suggested change
| return xerrors.Errorf("the input appears to be an array, only 1 role can be sent at a time") | |
| return xerrors.Errorf("only 1 role can be sent at a time") |
cli/organizationroles.go
Outdated
|
|
||
| var customRole codersdk.Role | ||
| if jsonInput { | ||
| // JSON Upload mode |
There was a problem hiding this comment.
Suggested change
| // JSON Upload mode |
I feel like the if already gives about as much context as this comment
cli/organizationroles.go
Outdated
| interactiveRole, newRole, err := interactiveOrgRoleEdit(inv, org.ID, client) | ||
| role := existingRole(inv.Args[0], existingRoles) | ||
| if role == nil { | ||
| return xerrors.Errorf("The role %s does not exist exists. If you'd like to create this role use the create command instead", inv.Args[0]) |
There was a problem hiding this comment.
Suggested change
| return xerrors.Errorf("The role %s does not exist exists. If you'd like to create this role use the create command instead", inv.Args[0]) | |
| return xerrors.Errorf("The role %s does not exist. If you'd like to create this role use the create command instead", inv.Args[0]) |
cli/organizationroles.go
Outdated
| } | ||
|
|
||
| if role := existingRole(customRole.Name, existingRoles); role == nil { | ||
| return xerrors.Errorf("The role %s does not exist exists. If you'd like to create this role use the create command instead", customRole.Name) |
There was a problem hiding this comment.
Suggested change
| return xerrors.Errorf("The role %s does not exist exists. If you'd like to create this role use the create command instead", customRole.Name) | |
| return xerrors.Errorf("The role %s does not exist. If you'd like to create this role use the create command instead", customRole.Name) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14239