feat(site): add webpush notification serviceworker #17123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtojek
reviewed
Mar 27, 2025
| @@ -71,6 +79,18 @@ export const NavbarView: FC<NavbarViewProps> = ({ | |||
| /> | |||
| </div> | |||
|
|
|||
| {enabled ? ( | |||
| subscribed ? ( | |||
| <Button variant="outline" disabled={loading} onClick={unsubscribe}> | |||
There was a problem hiding this comment.
Is it just for experimental purposes? Dropping a button on NavBar may look inconsistent. If this is permanent, perhaps ask Bruno for his guidance.
There was a problem hiding this comment.
Yep, just for experimental. We'll need to better integrate this later.
81b8c6e to
58cc953
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds webpush notification support by implementing a dedicated service worker and integrating related API and UI changes. Key changes include:
- Bundling and serving the service worker through Vite with proper proxy configuration
- Implementing the webpush notifications logic, including subscription management via a new React hook and API endpoints
- Updating tests to verify proper webpush payload handling and functionality
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| site/vite.config.mts | Configures service worker bundling and proxy endpoints |
| site/src/testHelpers/entities.ts | Updates mock build info to include a webpush public key |
| site/src/serviceWorker.ts | Implements service worker logic for push and notification click events |
| site/src/modules/dashboard/Navbar/NavbarView.tsx | Adds buttons to enable/disable webpush notifications |
| site/src/index.tsx | Registers the service worker for push notifications |
| site/src/contexts/useWebpushNotifications.ts | Implements a hook for managing webpush subscriptions |
| site/src/api/api.ts | Introduces API methods for creating and deleting webpush subscriptions |
| coderd/webpush/webpush_test.go | Updates tests with random notifications and payload assertions |
| coderd/webpush/webpush.go | Modifies the dispatcher to include a VAPID subscriber and logs errors with endpoint details |
| coderd/coderdtest/coderdtest.go | Updates test setup for the webpush dispatcher with the proper subscriber URL |
| cli/server.go | Integrates a check for HTTPS access URLs before initializing webpush notifications |
Comments suppressed due to low confidence (1)
coderd/webpush/webpush_test.go:239
- [nitpick] The parameters for assert.Equal are inverted. Swap the arguments so that the expected value comes first to improve error messages and consistency.
assert.Equal(t, r.Header.Get("content-encoding"), "aes128gcm")
mtojek
approved these changes
Mar 27, 2025
|
/cherry-pick release/2.21 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #17091
Original changes from https://github.com/coder/coder/commits/kyle/tasks/
Notes: