fix: handle vscodessh style workspace names in coder ssh #17154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9680d52 to
0154e6c
Compare
Parkreiner
approved these changes
Mar 28, 2025
| @@ -57,6 +58,7 @@ var ( | |||
| autostopNotifyCountdown = []time.Duration{30 * time.Minute} | |||
| // gracefulShutdownTimeout is the timeout, per item in the stack of things to close | |||
| gracefulShutdownTimeout = 2 * time.Second | |||
| workspaceNameRe = regexp.MustCompile(`[/.]+|--`) | |||
There was a problem hiding this comment.
I feel like we can make this Regex more specific to avoid false positives. I don't know if Go's version requires you to escape the . and /, but I'm worried the . is getting interpreted as a wildcard and not a literal period
I think we could go with something like \/|\.|--, which treats the . case, / case, and -- case as distinct. At least from the test inputs, I didn't see any cases where the dots and slashes could be joined together as a single pattern, which is what the current regex allows
There was a problem hiding this comment.
. is not interpreted as a wildcard inside [].
There was a problem hiding this comment.
Ah, that's right – forgot that regex classes stop that behavior
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where old ssh configs that use the
owner--workspace--agentformat will fail to properly use thecoder sshcommand since we migrated off thecoder vscodesshcommand.