feat: add dynamic parameters websocket endpoint #17165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3af6a57 to
18ff0b4
Compare
aslilac
commented
Apr 3, 2025
aslilac
commented
Apr 7, 2025
00de0bd to
a54058e
Compare
Emyrk
reviewed
Apr 10, 2025
Comment on lines
-91
to
+94
| "tailscale.com/types/opt.Bool": config.OverrideNullable(config.OverrideLiteral(bindings.KeywordBoolean)), | ||
| "tailscale.com/types/opt.Bool": config.OverrideNullable(config.OverrideLiteral(bindings.KeywordBoolean)), | ||
| "github.com/hashicorp/hcl/v2.Expression": config.OverrideLiteral(bindings.KeywordUnknown), |
There was a problem hiding this comment.
I was leaving a few comments about guts, and honestly the syntax for overriding types is just... unfortunate right now.
I ran out of time when working on guts, and threw in type overrides in the current state just to make things possible, but it's not easy to use.
So I just made a PR that makes the changes I was proposing: #17339
One day I'll fixup guts and make this easier to use.
There was a problem hiding this comment.
is it alright if we merge your pr into main after merging this one?
Emyrk
approved these changes
Apr 10, 2025
Comment on lines
-91
to
+94
| "tailscale.com/types/opt.Bool": config.OverrideNullable(config.OverrideLiteral(bindings.KeywordBoolean)), | ||
| "tailscale.com/types/opt.Bool": config.OverrideNullable(config.OverrideLiteral(bindings.KeywordBoolean)), | ||
| "github.com/hashicorp/hcl/v2.Expression": config.OverrideLiteral(bindings.KeywordUnknown), |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new /dynamic-parameters websocket endpoint, some tests for it, and a small bit of generic machinery.
Don't be scared by the line count! This PR is only like 400 lines of actual code, the vast majority of the diff is from go.sum