Skip to content

feat: add frontend for app statuses #17178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 1, 2025
+1,449 −36
Merged

feat: add frontend for app statuses #17178

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
acd5868
feat: add app status tracking to the backend
kylecarbs Mar 28, 2025
14ffd6b
Move workspace app and build fetching into errgroup
kylecarbs Mar 31, 2025
333d661
Fix linting errors and tests
kylecarbs Mar 31, 2025
a60a3b7
gen
kylecarbs Mar 31, 2025
1728330
feat: add frontend for app statuses
kylecarbs Apr 1, 2025
b47c2b0
Fix linting errors
kylecarbs Apr 1, 2025
bf83158
Fix formatting and linting
kylecarbs Apr 1, 2025
25809fc
Organize imports
kylecarbs Apr 1, 2025
28cc5b6
Fix imports
kylecarbs Apr 1, 2025
e6bc4de
Fix icon on mock app
kylecarbs Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move workspace app and build fetching into errgroup
  • Loading branch information
@kylecarbs
kylecarbs committed Apr 1, 2025
commit 14ffd6b080a973a88a7284fa950d86a5186ae0e4
7 changes: 0 additions & 7 deletions coderd/workspaces.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1988,13 +1988,6 @@ func (api *API) workspaceData(ctx context.Context, workspaces []database.Workspa
return workspaceData{}, err
}

// This query must be run as system restricted to be efficient.
// nolint:gocritic
appStatuses, err := api.Database.GetLatestWorkspaceAppStatusesByWorkspaceIDs(dbauthz.AsSystemRestricted(ctx), workspaceIDs)
if err != nil && !errors.Is(err, sql.ErrNoRows) {
return workspaceData{}, xerrors.Errorf("get workspace app statuses: %w", err)
}

data, err := api.workspaceBuildsData(ctx, builds)
if err != nil {
return workspaceData{}, xerrors.Errorf("get workspace builds data: %w", err)
Expand Down